Add configurable PUBLIC_URL for docker images#827
Add configurable PUBLIC_URL for docker images#827Nani0002 wants to merge 5 commits intoEricsson:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
mcserep
changed the title
mcserep
added
Kind: Bug ⚠️
Kind: Refactor 🔃
Target: WebGUI
|
@Nani0002 For some reason, all modified files in this PR show a complete change for them, not only for the affected lines. This makes hard to find the real changes for review; and will also mess up the history. I guess you have changed the line endings and that is the reason we see that the entire files were changed. Please fix it. You shall commit all files with Linux file endings. (That's the default behaviour for Git even on Windows, unless configured otherwise.) https://docs.github.com/en/get-started/git-basics/configuring-git-to-handle-line-endings |
For this reason, generating the TypeScript client from the Thrift specification fails as well: CI log: |
| }); | ||
|
|
||
| app.use('/', proxyHandler); | ||
| app.use("/", proxyHandler); |
There was a problem hiding this comment.
File should be kept executable.
There was a problem hiding this comment.
File should be kept executable.
There was a problem hiding this comment.
File should be kept executable.
There was a problem hiding this comment.
File should be kept executable.
| ENTRYPOINT ["tini", "--", "/usr/local/bin/entrypoint.sh"] | ||
|
|
||
| CMD ["CodeCompass_webserver", "-w", "/workspace", "-p", "8080"] | ||
| CMD ["sh", "-c", "node ../../webgui-new/scripts/patch-basepath.js && CodeCompass_webserver -w /workspace -p 8080"] |
There was a problem hiding this comment.
No, the source folder should not be in the Docker image or in the install location at all. There is an open PR #811 for that, but merging it required to fix this issue first. Instead, any script should be installed through CMake to the install location.
There was a problem hiding this comment.
File should be kept executable.
mcserep
left a comment
mcserep
left a comment
There was a problem hiding this comment.
Multiple occurrences of the /new were not updated at all, e.g.:
| Leaving this out of the command will start the web interface with no set path. | ||
| The new GUI will still be accessible in the /new path appended to the end of your URL. |
There was a problem hiding this comment.
Without running patch-basepath.js, how will the new GUI be accessible on the given path? The documentation says nothing about executing it, it is only done in the Dockerfile.
3 participants
No description provided.